[wp-trac] [WordPress Trac] #31654: List tables: Select All shouldn't be a column header

WordPress Trac noreply at wordpress.org
Wed Mar 18 17:58:09 UTC 2015

#31654: List tables: Select All shouldn't be a column header
 Reporter:  afercia         |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  4.1
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, accessibility

Comment (by afercia):

 Thanks for the clarification. Looks like there are still some small
 details to fix, for example the "inactive update" plugin checkbox needs
 some more padding. Also, a small 1px difference in alignments, see first
 screenshot below.

 Noticed also the plugins `<thead>` and `<tfoot>` should have borders like
 in all other tables, but since they're absolutely positioned out of the
 main table, they "look" without borders, see second screenshot. I'm really
 not sure why they're absolutely positioned, is that really needed? I don't
 see any reason for that but maybe I'm missing something. In the proposed,
 refreshed, patch they're back in place and have borders.

 Also, the plugins table `<thead>` and `<tfoot>` have a smaller height
 compared to all the other tables, it would be nice to be consistent and
 have the same height.

 See final result in the animated gif, a comparison between the plugins
 table and the pages table.

 Worth noting the current CSS forces to use crazy selectors, I'm not so
 proud of what I had to code here :) Waiting confidently for the
 [https://make.wordpress.org/core/2014/12/19/core-css-roadmap/ CSS roadmap
 to sanity] :)

 Small screens with patch # 4:


 Large screens, borders; small screens, no more borders:


 Patch # 5  result:


Ticket URL: <https://core.trac.wordpress.org/ticket/31654#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list