[wp-trac] [WordPress Trac] #31352: Media icons are not retina friendly

WordPress Trac noreply at wordpress.org
Tue Mar 17 01:41:14 UTC 2015

#31352: Media icons are not retina friendly
 Reporter:  iseulde                              |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.2
Component:  Media                                |     Version:  3.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch ui-feedback needs-testing  |     Focuses:  ui,
  dev-feedback                                   |  administration

Comment (by joemcgill):

 I found a view that I missed when updating these media icons.
 [attachment:31352.4.diff] adds support in the media list view (ignore
 '''31352.3.diff'''). Just a reminder, you will still need to manually add
 the images from [attachment:media-files-40px-optimized.zip].

 This still isn't a complete patch, because we need to account for times
 where the icon directory has been filtered and the 2x versions do not
 exist. Not sure the best way to check if the there is a way to see if a
 filter has been set on the icon directory within the  `media/views.js`, so
 it may be better to extend `wp_get_attachment_image_src()` to return a
 valid src and src-2x. On the other hand, if we were to just use SVGs
 instead of PNGs here, we could avoid adding a srcset at all and simplify
 the whole process.

 Would be interested in feedback on the preferred way forward.

Ticket URL: <https://core.trac.wordpress.org/ticket/31352#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list