[wp-trac] [WordPress Trac] #31645: Press This: Reject relative URLs when scraping source html

WordPress Trac noreply at wordpress.org
Mon Mar 16 14:50:34 UTC 2015


#31645: Press This: Reject relative URLs when scraping source html
--------------------------+--------------------
 Reporter:  kraftbj       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  Press This    |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------

Comment (by stephdau):

 So yes, I think we should deal with this inside `get_canonical_link()`
 instead, especially since it itself uses alternative data keys if a
 canonical link isn't available, some which might have the same symptoms.

 I'd do with something along the lines of [attachment:31645-make-fully-
 qualified.diff], and then make sure that whatever uses
 `get_canonical_link()` tests for en empty return (which we should have
 anyways, if we did not yet).

 My patch doesn't process blah.html, or ../blah.html, etc. Just /blah and
 //blah.com/blah, but simply for the sake of giving a simple example. It
 could.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31645#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list