[wp-trac] [WordPress Trac] #31616: Splitting request_filesystem_credentials into separate functions

[WordPress Trac]

#31616: Splitting request_filesystem_credentials into separate functions
----------------------------+------------------------------
 Reporter:  jipmoors        |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Filesystem API  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+------------------------------

Comment (by jipmoors):

 '''Patch functional description:'''

 * Added a function that allows for just retrieving filesystem credentials
 `get_filesystem_credentials`
 * Added a function just display the HTML form using supplied credentials
 and type `request_filesystem_credentials_form`
 * Added a function to verify all required attributes are present in
 credentials to know if the credentials are 'usable'
 `usable_filesystem_credentials`

 * Modified the `request_filesystem_credentials` to use the newly added
 functions to provide the functionality and output expected

 All functions have respect to previous functionality and some "type"
 checks have been duplicated. But this seemed impossible to avoid. Once the
 "type" is set it will be passed down, so it won't have to be retrieved
 again.

 This keeps the old (expected) functionality as it was and adds new ways to
 retrieve data and control output.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31616#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform