[wp-trac] [WordPress Trac] #26600: Search installed themes input has no submit button

WordPress Trac noreply at wordpress.org
Tue Mar 10 01:05:22 UTC 2015

#26600: Search installed themes input has no submit button
 Reporter:  grahamarmfield        |       Owner:  joedolson
     Type:  defect (bug)          |      Status:  reopened
 Priority:  high                  |   Milestone:  4.2
Component:  Themes                |     Version:  3.8
 Severity:  normal                |  Resolution:
 Keywords:  has-patch dev-        |     Focuses:  accessibility, javascript
  feedback                        |
Changes (by afercia):

 * keywords:  needs-patch => has-patch dev-feedback
 * focuses:  accessibility => accessibility, javascript


 New patch tries a different approach using `wp.a11y.speak()`, based on the
 returned value of `collection.count/collection.length` which already
 exists in `theme.js`. Seems to work nicely.
 A couple of issues though:
 - the value returned is just a number so the string used for feedback
 messages, to avoid translation issues, is "Number of Themes found: {n}".
 Open to suggestions for a better message. When 0, the message is "No
 themes found. Try a different search."
 - the most important issue is that the search should really not run
 '''while users are still typing''' their search terms. As far as I see, in
 `themes.php` (where it's not really a "search" but it's filtering the
 current set of installed themes) there's no delay at all, unless I'm
 missing something. In `theme-install.php` there's a fixed delay of 300ms
 that doesn't take into account the typing speed or edge cases with very
 long theme names.

 So, while still typing, you can get multiple, consecutive search results
 (and multiple external calls) causing multiple, consecutive, page updates.
 Each of these results will be announced to screen readers.
 A clever solution could be something like a "typing-intent" feature (name
 inspired by "hover-intent") and some help in implementing that would be
 greatly appreciated :)
 Any thoughts more than welcome.

Ticket URL: <https://core.trac.wordpress.org/ticket/26600#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list