[wp-trac] [WordPress Trac] #20319: $page value not being defaulted to 1 in the absence of cpage query var in get_next_comments_link()/get_previous_comments_link()

WordPress Trac noreply at wordpress.org
Thu Mar 5 03:56:25 UTC 2015


#20319: $page value not being defaulted to 1 in the absence of cpage query var in
get_next_comments_link()/get_previous_comments_link()
--------------------------+---------------------------
 Reporter:  MomDad        |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.2
Component:  Comments      |     Version:  3.0
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:  template
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"31617"]:
 {{{
 #!CommitTicketReference repository="" revision="31617"
 In `get_next_comments_link()`, ensure proper pagination when no 'cpage'
 query var is found.

 The 'cpage' query var is only set when using `comments_template()` to
 display
 comments. If displaying them in a context where 'cpage' is not yet set,
 the
 default value should be 1, not 0.

 Props MomDad, couturefreak.
 Fixes #20319.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/20319#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list