[wp-trac] [WordPress Trac] #31303: Add theme-browsing and theme-switching to the Customizer

WordPress Trac noreply at wordpress.org
Mon Mar 2 01:25:00 UTC 2015

#31303: Add theme-browsing and theme-switching to the Customizer
 Reporter:  celloexpressions  |       Owner:  markjaquith
     Type:  task (blessed)    |      Status:  closed
 Priority:  normal            |   Milestone:  4.2
Component:  Customize         |     Version:  trunk
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch         |     Focuses:  ui

Comment (by westonruter):

 Replying to [comment:7 ocean90]:
 > Replying to [comment:6 westonruter]:
 > > Attached [attachment:31303.3.diff] with some fixes for jshint and some
 improvements to escaping.
 > We don't escape translations like that.

 Why not? Isn't it generally a good idea in the case of malicious POT
 files? And it is being used once here, in
 customize-section.php#L350 class-wp-customize-section.php]:

 <h2><?php esc_html_e( 'Themes' ); ?>

 > I also can't see our build tools producing JSHint errors. Where did you
 get them from?

 Regarding the JSHint errors, see my [attachment:phpstorm-jshint-customize-
 controls.png] above. Specifically the issue is reported in JSHint within
 PhpStorm, although it is not reported from the command line JSHint. But
 actually, I saw that my PhpStrom was using JSHint 2.2. I just updated it
 to 2.5.10, and it is now not complaining about these lines. Nevertheless,
 the mixing of tabs and spaces here does not seem ideal.

Ticket URL: <https://core.trac.wordpress.org/ticket/31303#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list