[wp-trac] [WordPress Trac] #28603: Improve "previously approved comment" test for logged-in users

WordPress Trac noreply at wordpress.org
Sun Mar 1 06:16:27 UTC 2015


#28603: Improve "previously approved comment" test for logged-in users
------------------------------------+------------------
 Reporter:  nevermoor               |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  4.2
Component:  Comments                |     Version:  4.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------

Comment (by DrewAPicture):

 Some notes on [attachment:28603.3.diff]:

 * Patch still applies, unit tests pass
 * Adding `$user_id` here would constitute an 8th (!) parameter for
 `check_comment()`. Yikes.
 * If we do end up adding the `$user_id` parameter, we also need to add a
 changelog entry to the DocBlock mentioning that the new parameter was
 added e.g. "@since 4.2.0 The `$user_id` parameter was introduced."

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28603#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list