[wp-trac] [WordPress Trac] #32760: Customizer Menus: cannot save a menu with the same name as an existing menu

WordPress Trac noreply at wordpress.org
Mon Jun 29 05:27:37 UTC 2015


#32760: Customizer Menus: cannot save a menu with the same name as an existing menu
-------------------------------------+--------------------------
 Reporter:  designsimply             |       Owner:  westonruter
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.3
Component:  Customize                |     Version:  trunk
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+--------------------------

Comment (by westonruter):

 Replying to [comment:11 tywayne]:
 > Replying to [comment:9 celloexpressions]:
 > > Yeah, and possibly also add a red outline like we have if you try to
 add a link without a URL.
 >
 > There is a similar check in nav-menu.js, but it additionally checks to
 be sure the name isn't just blank spaces. Maybe consider adding that check
 here as well? Something like `if ( !name || !name.replace(/\s+/, '') )`

 Great point! I've addressed this now in [attachment:32760.3.diff].

 Any other concerns before this gets committed?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32760#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list