[wp-trac] [WordPress Trac] #23012: Refresh the code for the default widgets

WordPress Trac noreply at wordpress.org
Fri Jun 19 14:22:47 UTC 2015


#23012: Refresh the code for the default widgets
--------------------------------------+-----------------------------
 Reporter:  Viper007Bond              |       Owner:  chriscct7
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  Future Release
Component:  Widgets                   |     Version:  3.5
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+-----------------------------

Comment (by jdgrimes):

 On
 [https://core.trac.wordpress.org/attachment/ticket/23012/23012.diff#L421
 lines 424-5] `wp_kses()` is used on strings that are meant to be
 translated, but the `__()` function is omitted.

 Spacing issues with a couple of the periods on line 1046:

 {{{
 $title = '<a class="rsswidget" href="' . esc_url( $url ). '"><img
 style="border:0" width="14" height="14" src="'. esc_url( $icon ) . '"
 alt="RSS" /></a> <a class="rsswidget" href="' .esc_url( $link ) .'">' .
 $title . '</a>';
 }}}

 Also, there should probably be a newline at the end of the file.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23012#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list