[wp-trac] [WordPress Trac] #30921: "Cannot Remove Old Plugin" Obliterates files!

[WordPress Trac]

#30921: "Cannot Remove Old Plugin" Obliterates files!
-------------------------------------+------------------
 Reporter:  johnstonphilip           |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.3
Component:  Upgrade/Install          |     Version:  4.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------
Changes (by dd32):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 [attachment:30921.2.diff 30921.2.diff] covers attempting to alter the file
 permissions when it hits an unwritable file.

 For deletion, changing the permissions isn't entirely required, if we can
 change the permissions we can delete the file (even if we can't modify
 it). Changing permissions to enable writing however is a good way to test
 it's deletable without actually performing the deletion.

 The error message now copies the one from the core update:
 > The update cannot be installed because we will be unable to copy some
 files. This is usually due to inconsistent file permissions.

 If anyone else would like to give it further testing, that is the likely
 commit candidate pending no issues.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30921#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform