[wp-trac] [WordPress Trac] #32632: Update wp_setup_nav_menu_item() to stop overriding empty properties from supplied $menu_item

[WordPress Trac]

#32632: Update wp_setup_nav_menu_item() to stop overriding empty properties from
supplied $menu_item
-------------------------+------------------
 Reporter:  westonruter  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.3
Component:  Menus        |     Version:  3.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------

Comment (by azaozz):

 Looking at 32632.diff: replacing `empty()` with `! isset()` doesn't seem
 to break anything on the current Appearance => Menus screen. It has the
 potential for introducing edge cases that might break some plugins, but we
 can deal with these as they are reported.

 Fixing the docs for the `WP_Post` constructor sounds good.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32632#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform