[wp-trac] [WordPress Trac] #32541: Call to a member function do_items on a non-object ($wp_styles)

[WordPress Trac]

#32541: Call to a member function do_items on a non-object ($wp_styles)
---------------------------+--------------------
 Reporter:  Frozzare       |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.3
Component:  Script Loader  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+--------------------

Comment (by DrProtocols):

 The root cause of this issue is the change made on this ticket:

 https://core.trac.wordpress.org/ticket/32444#comment:43

 which according to the description is a ticket for "improving static
 analysis". Whilst the change that was made may well have accomplished that
 it also broke the functionality of the plugin.

 I believe there was no intention on the part of the author of that
 ticket/change to break the function but it happened because no attention
 was paid to the logic of the function and how the change impacted that.

 It would seem that the change should be reversed in order to "unbreak" the
 function and then if it is necessary to modify the function in some way
 related to the change that was made then this should be done with due
 attention to the logic of the function so it is not broken.

 I don't think it is the correct approach to try and "fix up" the current
 state of the function but better to restore the correct functionality and
 then review how to change the function without breaking it.

 So this change should be reverted:

 https://core.trac.wordpress.org/changeset/32597

 Thanks.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32541#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform