[wp-trac] [WordPress Trac] #26550: Some anchor links should be buttons in media microtemplates

[WordPress Trac]

#26550: Some anchor links should be buttons in media microtemplates
------------------------------+--------------------------------------------
 Reporter:  joedolson         |       Owner:  wonderboymusic
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.3
Component:  Media             |     Version:  3.5
 Severity:  normal            |  Resolution:
 Keywords:  has-patch dev-    |     Focuses:  ui, accessibility, javascript
  feedback                    |
------------------------------+--------------------------------------------
Changes (by afercia):

 * keywords:  needs-patch => has-patch dev-feedback
 * focuses:  accessibility => ui, accessibility, javascript


Comment:

 In the proposed patch (first pass):
 - all the non links are now buttons, except `refresh-attachment` which
 seems to be unused, will open a new ticket for this
 - introduce a `.button-link` CSS class for a basic button reset, first
 pass
 - JavaScript: the 'check' and 'close' icons (see screenshot) are now
 buttons, no need to attach a `keydown` event and no need for
 `preventDefault()`
 - JavaScript: prevents `toggleSelectionHandler` to fire when activating
 the 'check' and 'close' buttons, fixes #32540
 - translatable strings: updated the 'Remove' strings to be more
 descriptive when read out of context

 [[Image(https://cldup.com/3g3sxmI5BP.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26550#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform