[wp-trac] [WordPress Trac] #33073: Some strings need "no HTML entities" translator comments

[WordPress Trac]

#33073: Some strings need "no HTML entities" translator comments
-------------------------+------------------------------
 Reporter:  xibe         |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  I18N         |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:
-------------------------+------------------------------
Changes (by xibe):

 * keywords:  has-patch needs-testing =>


Comment:

 Replying to [comment:11 azaozz]:
 >
 > Would it work if we run `html_entity_decode()` when using these strings?
 This is the case for all strings that are outputted for use in JS and as
 far as I know there aren't any problems with entities there.

 Good call! Actually, I see that the feed-atom-comments.php and feed-
 rss2-comments.php strings are already enclosed in `ent2ncr()` -- and the
 feeds don't break with "By: %s" translated to "Par : %s", so it seems
 we're good here.

 For the mail related strings, I guess `html_entity_decode()` is indeed the
 better way, since it converts the entities to their applicable characters,
 whereas `ent2ncr()` "only" switches named entities to their numbered
 counterparts.

 If so, I can take care of the patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33073#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform