[wp-trac] [WordPress Trac] #32911: Review Customizer Nav Menus JS

WordPress Trac noreply at wordpress.org
Tue Jul 21 16:13:38 UTC 2015


#32911: Review Customizer Nav Menus JS
----------------------------+-----------------------------
 Reporter:  wonderboymusic  |       Owner:  wonderboymusic
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  4.3
Component:  Customize       |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  javascript
----------------------------+-----------------------------

Comment (by wonderboymusic):

 In [changeset:"33345"]:
 {{{
 #!CommitTicketReference repository="" revision="33345"
 Customizer: Nav Menus JS cleanup, first round

 * In `init`, settings should be fresh and set to default values before
 extending
 * When looping via `_.each`, pass `this` as 3rd arg to bind context
 * Settings should be encapsulated in the module, instead of being exposed
 as static class props
 * `currentRefreshMenuInstanceDebouncedCalls` should be encapsulated and
 renamed, instead of being the longest symbol in the entire codebase

 See #32911.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32911#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list