[wp-trac] [WordPress Trac] #33053: download_url() includes query string in temporary filenames

[WordPress Trac]

#33053: download_url() includes query string in temporary filenames
-------------------------------------------+------------------------------
 Reporter:  Hyperopic                      |       Owner:
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  Awaiting Review
Component:  Upgrade/Install                |     Version:  4.2.1
 Severity:  normal                         |  Resolution:
 Keywords:  reporter-feedback needs-patch  |     Focuses:
-------------------------------------------+------------------------------
Changes (by Hyperopic):

 * keywords:  reporter-feedback => reporter-feedback needs-patch


Comment:

 Replying to [comment:1 dd32]:
 > This should be fixed in 4.2.2 - #31811, can you verify if that does fix
 it?
 >
 > In the case of the above example, the temporary file should be based on
 `enfold.zip` only.

 No, it's definitely not resolved in 4.2.2, just tested on development
 machine and live site is now up to date too. I've got it working now with
 an edit to wp-admin/includes/file.php with line 457 in download_url()
 edited from
 {{{ $tmpfname = wp_tempnam($url); }}}
 to
 {{{ $tmpfname = wp_tempnam( parse_url( $url, PHP_URL_PATH ) ); }}}

 Unfortunately I've not had the time to sort out SVN and get a patch
 submitted.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33053#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform