[wp-trac] [WordPress Trac] #33004: WP_Text_Diff_Renderer_Table class's '_changed()' is having bug

WordPress Trac noreply at wordpress.org
Mon Jul 20 14:27:49 UTC 2015

#33004: WP_Text_Diff_Renderer_Table class's  '_changed()' is having bug
 Reporter:  vishalkakadiya     |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Revisions          |     Version:  4.2.2
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
Changes (by adamsilverstein):

 * keywords:   => reporter-feedback


 @vishalkakadiya: Thanks for the bug report!

 I'm not sure that blank line call is a bug, although clearly in your case
 it is producing unintended results.

 If you examine the constructed html for the 'split' diff view, you should
 see a series of rows consisting of three columns, a left hand 'removed'
 column, a middle spacer column, and a right hand added column. (see
 http://cl.ly/image/0V2m2i3I0O0N). Any html inside the diffs should be
 encoded and not break the layout.

 Removing the middle column is likely to have unintended consequences
 elsewhere as the entire page structure assumes three columns. Before I
 close this ticket as 'won't fix, I'd like to dig a bit more to see how you
 are getting into the situation your screenshot illustrates. Can you help
 by adding some additional detail?

 * Are you testing on wp 4.2 or trunk?
 * Anything special to reproduce this issue, do you see it only on that one
 post/revision, or something you see elsewhere as well?
 * Can you try reproducing with all plugins disabled and using the default
 * If the issue persists, can you provide a db dump of your posts table or
 just the part referencing this post and its revisions?


Ticket URL: <https://core.trac.wordpress.org/ticket/33004#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list