[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
--------------------------+------------------------------------------------
 Reporter:  jane          |       Owner:  obenland
     Type:  task          |      Status:  reopened
  (blessed)               |   Milestone:  4.3
 Priority:  normal        |     Version:  3.1
Component:  Customize     |  Resolution:
 Severity:  normal        |     Focuses:  ui, accessibility, administration
 Keywords:  has-patch     |
--------------------------+------------------------------------------------

Comment (by obenland):

 I've been working on moving cropping and the site icon preview into the
 media modal to attain feature parity between the Customizer and Settings
 versions. [attachment:16434.23.diff] is still a little buggy, but it
 accomplishes that. I was also able to monkey-patch imgAreaSelect to work
 on touch devices, I'm waiting to get the bugs from .23.diff fixed before
 submitting a new patch.

 With having both versions look the same and do the same, I'm now wondering
 if it still makes sense to keep both around or just keep the Customizer
 one. Opinions?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16434#comment:240>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform