[wp-trac] [WordPress Trac] #32975: Improve translation string in theme edit screen

WordPress Trac noreply at wordpress.org
Mon Jul 13 13:04:12 UTC 2015


#32975: Improve translation string in theme edit screen
--------------------------+-----------------------------
 Reporter:  ramiy         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  I18N          |    Version:  4.2.2
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 When translating the "`__( 'Header' )`" string to hebrew, we use it in the
 context of custom-header, because this string is used to link to
 "`themes.php?page=custom-header`".

 Source: https://core.trac.wordpress.org/browser/trunk/src/wp-includes
 /admin-bar.php#L735

 But it seems like the same string "`__( 'Header' )`" is used in the
 content of descripting the "`header.php`" file name.

 Source: https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/file.php#L21

 === The problem ===

 As a translator, I can't create two different translation strings. And the
 result is that in the theme edit screen, the header.php file description
 translated to "custom header" (in hebrew).

 === The solution ===

 We can replace "`__( 'Header' )`" with "`_x( 'Header', 'context' )`".

 Or we can use different strings, replacing "`__( 'Header' )`" with "`__(
 'Theme Header' )`".

 I personally prefer the second solution, as it adds more descriptive text
 to the user, but both solution do the job.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32975>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list