[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
--------------------------+------------------------------------------------
 Reporter:  jane          |       Owner:  obenland
     Type:  task          |      Status:  accepted
  (blessed)               |   Milestone:  4.3
 Priority:  normal        |     Version:  3.1
Component:  Customize     |  Resolution:
 Severity:  normal        |     Focuses:  ui, accessibility, administration
 Keywords:  ux-feedback   |
  has-patch               |
--------------------------+------------------------------------------------

Comment (by celloexpressions):

 [attachment:16434.17.diff] skips cropping automatically in the Customizer
 if the image is the right size and flex-crop is disabled (meaning the size
 is mandatory, not recommended, so the image can't be cropped anyway). Also
 uses the `full` image size as the default value, keeping with the way
 `WP_Customize_Media_Control` works, per Slack discussion with @obenland.

 Remaining questions/changes for the customizer side are more related to
 #29211, and whether there should be default server-side handling for
 cropped-image attachments so that devs can add cropped-image Customizer
 controls that "just work" rather than having to roll their own version of
 attachment duplication and saving. I'd like the developer experience to be
 as seamless as possible, and also think about potential future
 enhancements - core or otherwise - that will be enabled by setting the
 attachment context to the customizer control id by default.

 Thinking about it some more, I'm also okay with making the ajax filter
 based on the control id rather than its type, as long as we have default
 support for theme and plugin-added controls so that they don't need to use
 the filter unless they're doing custom stuff.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16434#comment:225>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform