[wp-trac] [WordPress Trac] #32154: Don't upgrade global tables for utf8mb4

[WordPress Trac]

#32154: Don't upgrade global tables for utf8mb4
--------------------------+---------------------
 Reporter:  ocean90       |       Owner:  dd32
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.2.3
Component:  Database      |     Version:  4.2
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------

Comment (by dd32):

 Something that's missing from this ticket description, is that the main
 issue here was that sites that were setup as single-site with a shared
 user table, ran the global updates on those shared user tables when they
 shouldn't have.

 > After these changes, the 4.2 branch and trunk have two different
 conditions for when global tables will be upgraded. Is that acceptable?

 As far as I can tell, the 4.2, and trunk changes although slightly
 different conditionals due to the additional network checks are about the
 same, unless I've missed something, which is entirely possible because DB
 upgrades are a complete maze.
 The 4.2 conditionals are not worse than in the past (they're as they
 should've been), and trunk conditionals appear to be better going forward.

 > Re: r33059: it looks like the 4.2 branch will still attempt to upgrade
 global tables on each site of each network. Can you confirm that it's not?
 As far as I can tell, it doesn't. And it didn't previously. The change is
 not to upgrade global tables on single site installs when
 `DO_NOT_UPGRADE_GLOBAL_TABLES` is defined.

 > Re: r33058: How does the new is_multisite() check prevent the upgrade
 routine from running twice
 `upgrade_network()` takes care of global tables in Multisite.
 `pre_schema_upgrade` is run for both Single site and Multisite, and
 handles the single site.
 Without it, if global table upgrades are enabled, the index would be
 dropped and added in `pre_schema_upgrade()`, and then dropped and added
 again in `upgrade_network()`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32154#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform