[wp-trac] [WordPress Trac] #32154: Don't upgrade global tables for utf8mb4

WordPress Trac noreply at wordpress.org
Fri Jul 3 05:37:11 UTC 2015


#32154: Don't upgrade global tables for utf8mb4
--------------------------+-----------------------
 Reporter:  ocean90       |       Owner:  dd32
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.2.3
Component:  Database      |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------

Comment (by dd32):

 > I understand. But we do use can in many places, and don't use should
 yet.
 It looks like the only place we use `should` is in the Background Update
 methods. It looks like all other things are mostly `can` as they test the
 ability to (or a setting), followed by filters.

 > We should be explicit, always.
 We actively discourage being explicit when not needed. We do not use `if (
 false === func() )` unless it's needed, we encourage `if ( ! func() )`
 instead.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32154#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list