[wp-trac] [WordPress Trac] #32817: Avoid HTML tags in translation strings (WP_Customize_Themes_Section)

WordPress Trac noreply at wordpress.org
Wed Jul 1 15:50:03 UTC 2015


#32817: Avoid HTML tags in translation strings (WP_Customize_Themes_Section)
----------------------------+-----------------------
 Reporter:  henrikakselsen  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.3
Component:  Customize       |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  wontfix =>
 * milestone:   => 4.3


Comment:

 Replying to [comment:4 obenland]:
 > We need the placeholder for RTL languages to be able to shift that value
 around.

 `.customize-action` is a block element, so there's no need to move the
 placeholder here: [attachment:32817.rtl.png].

 Generally, I don't think RTL languages have to shift placeholders often,
 text direction should take care of that.

 Replying to [comment:1 GaryJ]:
 > Instead of using `.` to echo, you can use `,`, which has a slight
 performance benefit, as it echos the values straight away, instead of
 building up into a single string first.

 I'd suggest leaving this discussion for #31950 and using concatenation for
 now for consistency with other core files.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32817#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list