[wp-trac] [WordPress Trac] #31167: SSH2/SFTP newline breaks path causes segfault and "Save Changes" missing in UI

WordPress Trac noreply at wordpress.org
Fri Jan 30 02:10:15 UTC 2015


#31167: SSH2/SFTP newline breaks path causes segfault and "Save Changes" missing in
UI
----------------------------+------------------------------
 Reporter:  thajekku        |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  4.1
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  administration
----------------------------+------------------------------

Comment (by dd32):

 This sounds like a strange and interesting bug, and i have absolutely no
 issues in trimming the paths here.

 The question that is on my mind though, is should this trimming be done
 within `run_command()` and only strip a suffixed `\r` & `\n` characters
 from the string? I struggle to see why any newline characters need to
 remain.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31167#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list