[wp-trac] [WordPress Trac] #31135: register_taxonomy() should call a _doing_it_wrong() when called with an empty taxonomy name

WordPress Trac noreply at wordpress.org
Mon Jan 26 04:40:24 UTC 2015


#31135: register_taxonomy() should call a _doing_it_wrong() when called with an
empty taxonomy name
----------------------------------------+------------------
 Reporter:  tyxla                       |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  4.2
Component:  Taxonomy                    |     Version:  3.0
 Severity:  minor                       |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => has-patch needs-unit-tests
 * type:  enhancement => defect (bug)
 * severity:  normal => minor
 * milestone:  Awaiting Review => 4.2


Comment:

 Hi @tyxla, thanks for the patch, that's a good catch. I think we can
 probably modify the existing `_doing_it_wrong()` call to account for both
 cases, maybe "Taxonomies must be between 1 and 32 characters in length."
 We also need a unit test covering the empty string case.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31135#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list