[wp-trac] [WordPress Trac] #29974: Focus handle at wrong place when you click reply

[WordPress Trac]

#29974: Focus handle at wrong place when you click reply
----------------------------------+----------------------------------------
 Reporter:  nhuja                 |       Owner:
     Type:  defect (bug)          |      Status:  reopened
 Priority:  normal                |   Milestone:  Awaiting Review
Component:  Comments              |     Version:  2.7
 Severity:  normal                |  Resolution:
 Keywords:  has-patch needs-      |     Focuses:  accessibility, javascript
  testing                         |
----------------------------------+----------------------------------------

Comment (by afercia):

 Thanks very much @adamsilverstein, @helen, glad to see some consensus here
 :)
 Noticed there are some hooks to take into account, some of them are
 available conditionally depending on discussion settings/logged in status.
 There are also some conditional messages. It looks like in the current
 patch the comment textarea is a bit misplaced, in the refreshed patch I'm
 trying to tweak it a bit. Not so happy to introduce a new `if` but
 couldn't think of a better way.

 Also, I would propose to:
 1. remove a useless title attribute on the "Log out?" link
 2. use an `aria-label` attribute on the "Logged in as {display name}", see
 what was already done for the "Reply to" link in r29822

 About 2. that link points to your profile but the link text is your
 display name, this could be confusing when read out of context. To be
 honest, I think it's not so clear also for sighted users :)
 See screenshot below: it's just your display name, doesn't say anything
 about the link target.

 [[Image(https://cldup.com/-rSHevBw3A.png)]]

 I understand that string now is not so nice for translation purposes, but
 it's not the only problematic string there. Open to suggestions and any
 thoughts welcome.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29974#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform