[wp-trac] [WordPress Trac] #25672: is_a() causing errors with get_users()

WordPress Trac noreply at wordpress.org
Fri Jan 16 02:46:07 UTC 2015


#25672: is_a() causing errors with get_users()
---------------------------------+-----------------------------
 Reporter:  dgdax                |       Owner:  wonderboymusic
     Type:  defect (bug)         |      Status:  closed
 Priority:  normal               |   Milestone:  4.2
Component:  General              |     Version:  3.6.1
 Severity:  normal               |  Resolution:  fixed
 Keywords:  has-patch 4.2-early  |     Focuses:
---------------------------------+-----------------------------

Comment (by nacin):

 Does this mean we should never add another `is_a()` to core? Who or what
 is enforcing that decision? It seems arbitrary. We must consider the added
 cost during implementation of new code in cases like this.

 As noted in this thread: `is_a()` and `instanceof` have slightly different
 behaviors, and negating `instanceof` is also weird (you have to use
 parentheses and such).

 I think that anyone who is looking for E_STRICT in PHP 5.2 deserves to
 have a full error log.

 Also, if you're using 5.3.7 or 5.3.8, least you can do is update to
 something secure. (Very few WP sites run these two versions.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25672#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list