[wp-trac] [WordPress Trac] #31024: Add a new hook to the first <option>-element of the archive widget dropdown

WordPress Trac noreply at wordpress.org
Thu Jan 15 16:55:53 UTC 2015


#31024: Add a new hook to the first <option>-element of the archive widget dropdown
---------------------------+-----------------------------
 Reporter:  floriansimeth  |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  Future Release
Component:  Widgets        |     Version:  4.1
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  template
---------------------------+-----------------------------

Comment (by westonruter):

 Instead of:

 {{{
 <option value=""><?php esc_attr_e( apply_filters(
 'widget_archives_dropdown_first', 'Select Month' ) ); ?></option>
 }}}

 It should actually do something like:

 {{{
 <option value=""><?php echo esc_attr( apply_filters(
 'widget_archives_dropdown_first', __( 'Select Month' ) ) ); ?></option>
 }}}

 As otherwise the string won't get translated properly.

 And the filter would probably be better named
 `widget_archives_dropdown_first_option_label`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31024#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list