[wp-trac] [WordPress Trac] #30988: Setting's default value doesn't apply on preview window

WordPress Trac noreply at wordpress.org
Wed Jan 14 19:09:47 UTC 2015


#30988: Setting's default value doesn't apply on preview window
-------------------------------------+-----------------------------
 Reporter:  Aniruddh                 |       Owner:  ocean90
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  4.1.1
Component:  Customize                |     Version:  4.1
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |     Focuses:  administration
-------------------------------------+-----------------------------
Changes (by westonruter):

 * keywords:  needs-testing needs-unit-tests has-patch => needs-testing has-
     patch
 * owner:  westonruter => ocean90
 * status:  assigned => reviewing


Comment:

 In [attachment:30988.2.diff]:

  * `9e00392` Use `require_once` instead of `require` in
 WP_Customize_Manager (for unit testing, but also good regardless)
  * `daf6183` Update `multidimensional` to account for an array overriding
 a string or object value (otherwise fatal error can ensue)
  * `6a86c92` Store the response of `value()` when calling `preview()` for
 use if no `post_value()` (this is the key commit for this ticket)
  * Add unit tests for `WP_Customize_Setting::__construct()` and
 `WP_Customize_Setting::preview()`, with 139 assertions. (See also #28579)

 Full changes in PR: https://github.com/xwp/wordpress-develop/pull/62/files

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30988#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list