[wp-trac] [WordPress Trac] #30891: Unchecked property overloading is detrimental to OOP.

[WordPress Trac]

#30891: Unchecked property overloading is detrimental to OOP.
--------------------------+------------------
 Reporter:  aercolino     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  General       |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------

Comment (by wonderboymusic):

 In [changeset:"31135"]:
 {{{
 #!CommitTicketReference repository="" revision="31135"
 In `WP_Text_Diff_Renderer_Table`:

 * In [28525], `$_diff_threshold`, `$inline_diff_renderer`, and
 `$_show_split_view` were marked `protected`; magic methods were also
 added.
 * The magic methods should only perform operations on a whitelisted set of
 properties, now specified in `$compat_fields`
 * Remove `__call()`, is unnecessary and can wreak havoc on the parent
 class.

 This class is used in one place: `wp_text_diff()`.

 See #30891.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30891#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform