[wp-trac] [WordPress Trac] #30891: Unchecked property overloading is detrimental to OOP.

[WordPress Trac]

#30891: Unchecked property overloading is detrimental to OOP.
--------------------------+------------------
 Reporter:  aercolino     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  General       |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------

Comment (by wonderboymusic):

 I am going to go through each class one by one right now and see what I
 can see.

 For starters, take `Custom_Background`: 2 of the properties were marked
 `private` (following the `@param` annotation), but they are used as
 `add_action` callbacks, which means they have to be public.

 I will try to correct usage before adding any `_doing_it_wrong()` logic,
 etc

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30891#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform