[wp-trac] [WordPress Trac] #30945: WP_Upgrader: Incorrect plugin folder after updating from remote (non-WP) URL

[WordPress Trac]

#30945: WP_Upgrader: Incorrect plugin folder after updating from remote (non-WP)
URL
-------------------------------+------------------------------
 Reporter:  miyarakira         |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Plugins            |     Version:  4.1
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------

Comment (by miyarakira):

 Aha, I finally figured out how to package the zip file as WordPress
 expects.  This is not so relevant here as it pertains to `gulp-zip`, but
 this does it correctly:

 {{{
  return gulp.src(files, { base:'../' })
    .pipe(zip(slug+'.zip'))
    .pipe(gulp.dest(dest));
 }}}

 Setting the base directory to `../` (one above the plugin folder) zips all
 files under a root folder with the plugin name.  I was able to confirm
 this using `unzip -l plugin.zip` and listing its contents, as well as
 installing and updating the plugin.

 OK, so I believe this ticket can be closed without further ado. Thank you
 so much for the input! Today I filed two tickets, set up a dev version of
 WordPress via SVN so I can submit patches, and dug around in core like
 never before.  Whew, that was sure a learning process.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30945#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform