[wp-trac] [WordPress Trac] #30945: WP_Upgrader: Incorrect plugin folder after updating from remote (non-WP) URL

[WordPress Trac]

#30945: WP_Upgrader: Incorrect plugin folder after updating from remote (non-WP)
URL
-------------------------------+------------------------------
 Reporter:  miyarakira         |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Plugins            |     Version:  4.1
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------

Comment (by miyarakira):

 I see.. Yes, I had to resort to the first format, because if I put all
 files in a root folder as in the second format, I encountered an error:
 "The package could not be installed. The plugin contains no files."  I can
 provide a zip example of this as well.

 As for the query string, I worked around this issue by modifying .htaccess
 in the updates folder, so that a request to updates/*.zip will get handled
 by the updater's index.php.  That way I can specify the zip file in the
 URL (as well as the real request in the query string).

 It would be helpful if the folder name `plugin.tmp` could be fixed for zip
 files in the first format. I believe somewhere in `WP_Upgrader::run()`,
 between unpack and install package?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30945#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform