[wp-trac] [WordPress Trac] #29803: Silent failure when wp_embed_register_handler() has a non-public callback

WordPress Trac noreply at wordpress.org
Thu Jan 1 19:28:52 UTC 2015


#29803: Silent failure when wp_embed_register_handler() has a non-public callback
---------------------------+------------------------------
 Reporter:  paulschreiber  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Embeds         |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------
Changes (by wonderboymusic):

 * keywords:  dev-feedback needs-unit-tests => has-patch


Comment:

 Lemme think about this. The embed handler not working should be enough of
 a sign that that your method has problems. I would argue against making
 classes where every method is static and a few are marked `private` for
 fun. Action handlers have to be `public`, always.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29803#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list