[wp-trac] [WordPress Trac] #18132: Misleading message when deleting a user with no sites

[WordPress Trac]

#18132: Misleading message when deleting a user with no sites
--------------------------------------+------------------------
 Reporter:  danielbachhuber           |       Owner:  Idealien
     Type:  enhancement               |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.2
Component:  Users                     |     Version:
 Severity:  trivial                   |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  multisite
--------------------------------------+------------------------

Comment (by Idealien):

 Replying to [comment:13 jeremyfelt]:
 > @Idealien - This is looking really good, thanks! I'm going to think
 about the markup a bit and test with a long list of users, but we're
 almost there.

 Thx. This is my first real core code effort and enjoying the right sized
 scope for it.

 Do either of the two options mocked up below feel like a better approach?

 '''A) Inline User Notice'''[https://cloudup.com/cohAeZh7SSf]

 * Removes the extra loop at top listing all users set for deletion at the
 top.
 * Display a line identifying each user that has no content in the existing
 set with a message indicating they will be deleted.

 From code perspective it'd be adding an else condition to

 {{{
 $blogs = get_blogs_of_user( $user_id, true );
 if ( !empty( $blogs ) ) {
    //current per user output
 }
 }}}

 '''B) Isolated Cases at the Bottom'''[https://cloudup.com/c4A59cpujjQ]
 During the main loop of this function store the list of user_ids that have
 no blogs as array and display them at the bottom indicating they will also
 be deleted.

 Both involve another string for translation and seem like similar amount
 of code. My $0.02 would vote for A) because it keeps the list alphabatized
 and consistent experience. But I also don't use Network form of WP so
 would value others opinions more than my own on this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18132#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform