[wp-trac] [WordPress Trac] #30380: get_transient doesn't check the return of get_option

WordPress Trac noreply at wordpress.org
Fri Feb 13 17:00:49 UTC 2015


#30380: get_transient doesn't check the return of get_option
---------------------------------+--------------------------
 Reporter:  jamesgol             |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  normal               |   Milestone:  4.2
Component:  Options, Meta APIs   |     Version:  2.8
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 4.2-early  |     Focuses:  performance
---------------------------------+--------------------------

Comment (by ocean90):

 The patch makes sense at first glance, but it's worth mentioning that
 `false < time()` is true, means $transient_option will be deleted from the
 database. Call it a clean up for broken transients. Maybe we should only
 avoid the `delete_option( $transient_timeout ); ` call?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30380#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list