[wp-trac] [WordPress Trac] #31300: redirect_canonical returns too early

[WordPress Trac]

#31300: redirect_canonical returns too early
------------------------------------+------------------------------
 Reporter:  stephenharris           |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Canonical               |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------------------
Changes (by stephenharris):

 * keywords:   => has-patch dev-feedback


Comment:

 Attached patch passes all canonical group unit tests, with one skipped
 (open trac ticket). My only concern which this patch is that
 `redirect_canonical()` seems to modify the `$requested_url` between where
 the early return was and the filter is. I'm confused as to why it modifies
 the requested URL not the redirect URL, but in my opinion this issue is
 independent of this ticket.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31300#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform