[wp-trac] [WordPress Trac] #28873: JavaScript code for adding bookmarklet Press This is hard to access with keyboard only

[WordPress Trac]

#28873: JavaScript code for adding bookmarklet Press This is hard to access with
keyboard only
------------------------------------+------------------------------
 Reporter:  rianrietveld            |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Press This              |     Version:  3.8
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+------------------------------

Comment (by azaozz):

 28873.4.patch looks good. Couple of things:

 - If we need IDs for aria, we can remove the classes (don't see the
 `pressthis-code-wrap` ID used anywhere).
 - If the animation (slideToggle) is "messing up" with the keyboard
 navigation/accessibility, we can remove it. Usually "jumpy" UI is worse
 UX, but...

 These changes also need to be added to options-writing.php. The Press This
 button/link is shown in two places :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28873#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform