[wp-trac] [WordPress Trac] #35274: Break-out conditional in allow_subdomain_install()

WordPress Trac noreply at wordpress.org
Thu Dec 31 18:04:24 UTC 2015


#35274: Break-out conditional in allow_subdomain_install()
--------------------------------+-----------------------------
 Reporter:  stevegrunwell       |      Owner:
     Type:  enhancement         |     Status:  new
 Priority:  normal              |  Milestone:  Awaiting Review
Component:  Networks and Sites  |    Version:  trunk
 Severity:  normal              |   Keywords:
  Focuses:  multisite           |
--------------------------------+-----------------------------
 Attached patch expands the conditional within
 `allow_subdomain_install()`with better inline documentation, replaces the
 IP address regex with `filter_var( $var, FILTER_VALIDATE_IP )`
 ([[http://us3.php.net/manual/en/function.filter-var.php supported in PHP
 5.2.0+]), and adds unit tests.

 This came about while working on a refresh for #22330, trying to add
 missing unit tests along the way, and includes one of the regex changes
 from @nacin's patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35274>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list