[wp-trac] [WordPress Trac] #34962: Issues with wp_get_document_title function causing problems with document titles

WordPress Trac noreply at wordpress.org
Thu Dec 31 03:50:53 UTC 2015


#34962: Issues with wp_get_document_title function causing problems with document
titles
--------------------------------------+-----------------------
 Reporter:  kasia_codeword            |       Owner:  obenland
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.4.1
Component:  Themes                    |     Version:  4.4
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------

Comment (by peterwilsoncc):

 On manual testing, this looks good. [attachment:34962.3.diff] updates a
 comment in the second patch, highlighted below.

 `/src/` looks ready to commit.

 {{{#!diff
 -       // If on the home or front page, use the site title.
 -       } elseif ( is_home() && is_front_page() ) {
 +       // If on the front page, use the site title.
 +       } elseif ( is_front_page() ) {
 }}}

 Unit tests look good, but will defer to others as they're not my strong
 point.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34962#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list