[wp-trac] [WordPress Trac] #35249: Unit tests should pass

[WordPress Trac]

#35249: Unit tests should pass
------------------------------+------------------------------
 Reporter:  jrf               |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------------------

Comment (by dossy):

 @jrf - I suppose the question is whether or not it's a good idea to have
 the default character set on a database set to `utf8mb4` - do all of the
 text columns really need to use that character set?  Or, if we're going to
 say "it's 2015, we should be able to shove `utf8mb4` in any text column"
 then we probably should be defining our database schema to use more
 conservative prefix indexes on text columns that aren't `FULLTEXT`
 indexes.

 While InnoDB allows prefix indexes of up to 3072 bytes using the
 `innodb_large_prefix` setting, it was only added to MySQL in 5.5, and
 `FULLTEXT` indexes since 5.6, but WordPress supports MySQL back to 5.0, so
 using 5.5+ and 5.6+ only features are probably a no-no.

 I'm curious, how did your test database get its default character set
 changed to `utf8mb4` anyway?  That's definitely unusual, otherwise these
 tests would have failed for more people ...

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35249#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform