[wp-trac] [WordPress Trac] #35229: Stop generating `wp-admin.min.css`

WordPress Trac noreply at wordpress.org
Sat Dec 26 11:33:59 UTC 2015


#35229: Stop generating `wp-admin.min.css`
---------------------------+-----------------------------
 Reporter:  dd32           |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  4.5
Component:  Script Loader  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  administration
---------------------------+-----------------------------

Comment (by dd32):

 > Package size for regular releases won't be changed significantly, full
 package sizes would increase by 88K as we'd no longer get the benefit of
 the CSS minification process combining some CSS rules which are currently
 in separate files. (Currently wp-admin/css is 2,240KB and would be 2,328KB
 after this proposal)

 Turns out that the increase was partly due to `login.css` `@import`ing
 `forms.css` and `l10n.css`.

 [attachment:35229.2.diff] instead moves those into the script loader too,
 and ultimately causes `wp-login.php` to use `wp-admin/load-styles.php`.
 I'm a little hesitant to introduce a reliance upon `wp-admin` php to `wp-
 login.php`, however we're already including `wp-admin/css/*` the harm
 seems minimal.

 [attachment:35229.2.diff] also added the "new" styles to `$rtl_styles`
 which was missed in the first iteration. After this new change including
 `wp-login.php` the size difference is down to 40K (current: 2,240K, after:
 2,280K)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35229#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list