[wp-trac] [WordPress Trac] #35084: check for post status in get_page_uri causes issues with permalinks

[WordPress Trac]

#35084: check for post status in get_page_uri causes issues with permalinks
---------------------------------------------+-----------------------
 Reporter:  tharsheblows                     |       Owner:  netweb
     Type:  defect (bug)                     |      Status:  assigned
 Priority:  normal                           |   Milestone:  4.4.1
Component:  Permalinks                       |     Version:  4.4
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+-----------------------

Comment (by dd32):

 [attachment:35084.3.diff] here does indeed fix the issue as provided here,
 that non-publish public statuses are not being added to URI's.
 However, I think [34001] should be reverted.

 Previously, a URI such as `/page/trashed_page/child/` was the returned
 URI, and was the URI which the page could be accessed on.
 Now, the URI will be returned as `/page/child/` and will 404, however,
 `/page/trashed_page/child/` will continue to return the page as expected.

 I think the original issue in #15963 was that pages that were removed, ie.
 database row removed, would cause a PHP Notice.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35084#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform