[wp-trac] [WordPress Trac] #35171: Publish box: the revisions count and the revisions limit numbers mismatch

[WordPress Trac]

#35171: Publish box: the revisions count and the revisions limit numbers mismatch
--------------------------+-----------------------------
 Reporter:  afercia       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Revisions     |    Version:  4.4
 Severity:  normal        |   Keywords:
  Focuses:  ui            |
--------------------------+-----------------------------
 Noticed while investigating on #35029: probably an edge case but when a
 post has an autosave, the Revisions count number includes the autosave
 while the revisions limit number refers to revisions - autosave. See in
 the screenshot below:

 [[Image(https://cldup.com/F9hLP-9YZn.png)]]

 I guess this is a bit confusing for users, it's really not clear at first
 sight why the first number is "4" and the second number is "3". This
 inconsistency is going to be more evident now that in #35029 proposes to
 show the revisions limit warning in plain text.

 As far as I see, `wp_get_post_revisions()` returns also autosaves because
 technically they're "revisions". See also `wp_is_post_autosave()`.

 The only reference I've found is in the Codex:
 https://codex.wordpress.org/Revisions#Revision_Options
 (when the revisions limit is set to) (int) > 0: store that many revisions
 (+1 autosave) per post.

 Open to suggestions, maybe the warning should say "the last n revisions
 and 1 autosave"?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35171>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform