[wp-trac] [WordPress Trac] #34475: get_comment_link incorrect page number in returned url.

WordPress Trac noreply at wordpress.org
Thu Dec 17 16:46:43 UTC 2015


#34475: get_comment_link incorrect page number in returned url.
-------------------------------------------------+-------------------------
 Reporter:  Property118                          |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Comments                             |  Review
 Severity:  normal                               |     Version:  4.3.1
 Keywords:  reporter-feedback needs-patch        |  Resolution:
  needs-unit-tests                               |     Focuses:
-------------------------------------------------+-------------------------
Changes (by boonebgorges):

 * keywords:   => reporter-feedback needs-patch needs-unit-tests


Comment:

 Hi @Property118 - I'm circling back around to this ticket. Sorry for the
 delay while we worked on 4.4.

 It's a bit perplexing that changing the "parent" parameter for the comment
 query would make a difference for you. You originally stated that threaded
 comments are disabled on your site. This should mean that all comments on
 the site have parent=0. This suggests that, at some point in the past, you
 had enabled threaded comments on your site. Can you verify?

 For cases like this one, maybe there should be a switch in
 `get_page_of_comment()` that omits the `parent` param when comment
 threading is disabled.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34475#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list