[wp-trac] [WordPress Trac] #35112: Screen Options in Appearance -> Menu not saved correctly sometimes

[WordPress Trac]

#35112: Screen Options in Appearance -> Menu not saved correctly sometimes
----------------------------+-----------------------------
 Reporter:  Asgaros         |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  4.4.1
Component:  Administration  |     Version:  4.4
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, javascript
----------------------------+-----------------------------

Comment (by Asgaros):

 @afercia Thanks for the patch! The ''Screen options'' in ''the Appearance
 -> Menu'' area are working great with it.

 But I think I found another related problem. Here are the relevant steps
 to reproduce it:

 '''Step 1:''' Lets assume that in the first step all checkboxes are
 selected again.

 [[Image(http://fs5.directupload.net/images/151215/7hx5hp2r.png)]]

 '''Step 2:''' Click on ''Manage in Customizer''

 '''Step 3:''' Click the ''settings'' icon. All checkboxes are selected. So
 far so good.

 [[Image(http://fs5.directupload.net/images/151216/76fyx42y.png)]]

 '''Step 4:''' Now de-select '''one''' checkbox, refresh the page and click
 the ''settings'' icon again. '''All''' checkboxes are selected again now.

 If I change checkboxes more than one time in this step, everything is
 saved correctly. It looks like the first AJAX request is missing some
 parameters/data.

 '''Example:'''

 When i de-select ''Link Target'' in '''Step 4''' this request-data will be
 sent:

 [[Image(http://fs5.directupload.net/images/151216/cd5pzyjr.png)]]

 But it should send this request-data (which will be sent when I un-select,
 select and un-select the checkbox again):

 [[Image(http://fs5.directupload.net/images/151216/sjlvdysu.png)]]

 I hope it helps! :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35112#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform