[wp-trac] [WordPress Trac] #35045: Responsive images not added when effective scheme differs from image src scheme

[WordPress Trac]

#35045: Responsive images not added when effective scheme differs from image src
scheme
-------------------------------------------------+-------------------------
 Reporter:  webaware                             |       Owner:
     Type:  defect (bug)                         |  johnbillion
 Priority:  normal                               |      Status:  reviewing
Component:  Media                                |   Milestone:  4.4.1
 Severity:  normal                               |     Version:  4.4
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:  template
-------------------------------------------------+-------------------------

Comment (by joemcgill):

 > Was also thinking we can move the "URL exists in image meta" check to
 wp_calculate_image_srcset()

 I was thinking about this again earlier today while discussion #35102.
 Moving this logic to `wp_calculate_image_srcset()` streamlines the code a
 little bit and has the added benefit allowing the filter to still be
 reachable by plugin authors who have rewritten image URLs for whatever
 reason (e.g., CDNs, etc.).

 [https://core.trac.wordpress.org/attachment/ticket/35045/35045.4.diff
 35045.4.diff] is a first pass at what this would look like if we moved the
 logic from
 [https://core.trac.wordpress.org/attachment/ticket/35045/35045.2.diff
 35045.2.diff] into `wp_calculate_image_srcset()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35045#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform