[wp-trac] [WordPress Trac] #35032: Shiny plugin updates fails if slug has special characters

WordPress Trac noreply at wordpress.org
Mon Dec 14 23:36:47 UTC 2015


#35032: Shiny plugin updates fails if slug has special characters
-------------------------------------+------------------------------
 Reporter:  khag7                    |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------------------

Comment (by adamsilverstein):

 Replying to [comment:7 khag7]:
 > That would involve doing something like `slug =
 slug.replace(/([^A-Za-z0-9_\-])/g,"\\$1" )` throughout the js anywhere a
 slug is used in a jQuery selector string.
 >

 This is a reasonable suggestion if we are going to continue using slug. we
 have switched to using the plugin name in some cases already, however i
 see we are still using slug so this is still an issue. lets keep working
 on this in the plugin.

 Does your existing patch resolve the issue in core? can you please refresh
 with @SergeyBiryukov 's feedback? also, can you offer some steps to
 reproduce? how can i create a plugin with a slug using special characters?

 Thanks.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35032#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list