[wp-trac] [WordPress Trac] #34976: Plug ins fail to update after WP 4.4 installed

WordPress Trac noreply at wordpress.org
Sat Dec 12 23:09:20 UTC 2015


#34976: Plug ins fail to update after WP 4.4 installed
----------------------------+--------------------
 Reporter:  patdundee       |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  4.4.1
Component:  Filesystem API  |     Version:  4.4
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+--------------------

Comment (by mensmaximus):

 Replying to [comment:66 dossy]:
 > Your approach destructively clobbers a file which you only assume does
 NOT exist in the target location, requires write privileges to the target
 location in order to function, and requires potentially up to 3 extra FTP
 commands *per invocation of `exists()`*.  Sorry, I think this is a bad
 solution, for these reasons.

 But it works with any FTP server not complying to the RFC. And it is just
 an approach. I never said this is the perfect implementation. This
 approach can be reached in many ways.

 Regarding your objections:
 - If you do not have write privileges the whole update will fail.
 - The filename can be the result of a nonce or a timestamp or what ever.
 - The test can be done right after the login to reduce the overhead to 3
 extra ftp commands. Whether -a is necessary can than be stored into a
 transient or the public $link var (make it an array and change some
 function calls)

 To much changes? Just revert back to the way 4.3.1 does it. But having a
 solution to catch only one exception and to miss many others is imho no
 solution.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34976#comment:67>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list